Repository navigation
fix(models): lucy-latest geometry follows lucy-2.6 (1280x720) - #19
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
decartdev
approved these changes
Nov 8, 2026
decartdev
left a comment
decartdev
left a comment
There was a problem hiding this comment.
LGTM (approved at Adir's request).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server now resolves
lucy-latesttolucy-2.6(DecartAI/api companion PR). The C++ registry still gavelucy-latestthe old Lucy 2.1 shape (1088×624), so C++ callers using the alias captured at a different resolution than the model actually serving them. The other SDKs already use 1280×720 here.test_models.cppnow checks thatlucy-latestis 1280×720, like the existinglucy-vton-latestchecks. Verified locally by building with-DDECART_BUILD_REALTIME=OFF:decart_testspasses, andclang-format --dry-run --Werrorreports nothing on the touched files.Link to Devin session: https://app.devin.ai/sessions/e0721d006eec47b3a020d92511e1194b
Open in Devin Desktop: https://app.devin.ai/desktop/session/e0721d006eec47b3a020d92511e1194b?variant=devin
Requested by: @AdirAmsalem